![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
Back in 2003 when I was working for $hateful_defence_contractor, we were dealing with a lot of quantities expressed in dB. Occasionally there was a need to add these things - no, I can't remember why. Total power output from multiple sources, or something. Everyone cursed about this. So I wrote a desk calculator script, along these lines:
[I also tried to write a Haskell version using System.Eval.Haskell, but I got
No, I thought of it as evil because it's doing an ugly thing: superficially altering code with regexes and then using string
Needless to say, it was the most successful piece of code I wrote in the year I spent in that job.
I was talking about string
The lack of external dependencies (also a virtue of the Python version, which depends only on core modules) was very much intentional: I wrote my program so it could be trivially distributed (by samizdat, if necessary). Most of my colleagues weren't Perl programmers, and if I'd said "First, install
So, what do you all think? Is it evil or lovely? Or both? And what's the most evil piece of code that you've written?
Edit: Aaron also pointed me at this program, which is both lovely and evil in a similar way. If you don't understand what's going on, type
#!/usr/bin/perl
print "> ";
while (<>) {
s|-?\d+(\.\d+)?([eE][-+]?\d+)?|10**($&/10)|oeg;
print 10*log(eval $_)/log(10)."\n> ";
}I've always thought of this as The Most Evil Code I've Ever Written. For those of you who don't speak fluent regex, it reads a line of input from the user, interprets everything that looks like a number as a number of decibels, replaces each decibel-number with the non-decibel equivalent, evaluates the resulting string as Perl code, and then converts the result back into decibels. Here's an example session:> 1 + 1 4.01029995663982 > 10 * 10 20 > cos(1) -5.13088257108395Some of you are no doubt thinking "Well of course that code's evil, it's written in Perl!" But no. Here's the same algorithm written in Python:
#!/usr/bin/python -u
import re, math, sys
def repl(match):
num = float(match.group(0))
return str(10**(num/10))
number = re.compile(r'-?\d+(\.\d+)?([eE][-+]?\d+)?')
while 1:
line = sys.stdin.readline()
if len(line) == 0:
break
line = re.sub(number, repl, line)
print 10*math.log10(eval(line)) If anything, the Perl version is simpler and has lower accidental complexity. If Perl's not the best imaginable language for expressing that algorithm, it's damn close.[I also tried to write a Haskell version using System.Eval.Haskell, but I got
undefined reference to `__stginit_pluginszm1zi5zi1zi4_SystemziEvalziHaskell_' errors, suggesting my installation of cabal is b0rked. Anyone know what I need to do to fix it? Also, I'm sure my Python style can be greatly improved - suggestions most welcome.]No, I thought of it as evil because it's doing an ugly thing: superficially altering code with regexes and then using string
eval? And who the hell adds decibels, anyway?Needless to say, it was the most successful piece of code I wrote in the year I spent in that job.
I was talking about string
eval to Aaron Crane the other day, and I mentioned this program. His response surprised me:I disagree; I think it’s a lovely piece of code. It may not be a beautiful jewel of elegant abstractions for a complex data model, true. But it’s small, simple, trivial to write, works on anything with a Perl interpreter (of pretty much any vintage, and with no additional dependencies), and clearly correct once you’ve thought about the nature of the arithmetic you’re doing. While it’s not something you’d ship as part of a safety-critical system, for example, I can’t see any way it could be realistically improved as an internal tool, aimed at users who are aware of its potential limitations.[Full disclosure: the Perl version above didn't work first time. But the bug was quickly found, and it did work the second time :-)]
The lack of external dependencies (also a virtue of the Python version, which depends only on core modules) was very much intentional: I wrote my program so it could be trivially distributed (by samizdat, if necessary). Most of my colleagues weren't Perl programmers, and if I'd said "First, install
Regexp::Common from CPAN...", I'd have lost half my potential audience. As it was, the tool was enthusiastically adopted.So, what do you all think? Is it evil or lovely? Or both? And what's the most evil piece of code that you've written?
Edit: Aaron also pointed me at this program, which is both lovely and evil in a similar way. If you don't understand what's going on, type
perl -e 'print join q[{,-,+}], 1..9' and perl -e 'print glob "1{,-,+}2"' at the command-line.Tags:
![[livejournal.com profile]](https://www.dreamwidth.org/img/external/lj-userinfo.gif){kind=small}